From 1a1f582ab363f4621951b636f4c31d86802f57c2 Mon Sep 17 00:00:00 2001 From: Lorenzo Pichilli Date: Fri, 14 Oct 2022 02:14:46 +0200 Subject: [PATCH] fixed ios findInteractionController.activeFindSession on onFindResultReceived, updated README --- .all-contributorsrc | 2 +- CHANGELOG.md | 4 ++++ README.md | 2 +- example/ios/Flutter/flutter_export_environment.sh | 5 +++-- .../FindInteraction/FindInteractionChannelDelegate.swift | 4 ++-- 5 files changed, 11 insertions(+), 6 deletions(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index c9e680d8..52261445 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -554,7 +554,7 @@ "login": "bagedevimo", "name": "Ben Anderson", "avatar_url": "https://avatars.githubusercontent.com/u/1319813?v=4", - "profile": "http://www.acidic.co.nz", + "profile": "https://www.acidic.co.nz", "contributions": [ "code" ] diff --git a/CHANGELOG.md b/CHANGELOG.md index b1862844..a1c8c2ba 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,6 +28,10 @@ - Removed `URLProtectionSpace.iosIsProxy` property - `historyUrl` and `baseUrl` of `InAppWebViewInitialData` can be `null` +## 5.5.0+1 + +- Fixed README + ## 5.5.0 - Added Android direct camera capture feature diff --git a/README.md b/README.md index 5c802ce6..efa7d229 100755 --- a/README.md +++ b/README.md @@ -153,7 +153,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d Kamil Powałowski
Kamil Powałowski

💻 Akio Yamamoto
Akio Yamamoto

💻 mohenaxiba
mohenaxiba

💻 - Ben Anderson
Ben Anderson

💻 + Ben Anderson
Ben Anderson

💻 Daan Poron
Daan Poron

🛡️ ふぁ
ふぁ

💻 diff --git a/example/ios/Flutter/flutter_export_environment.sh b/example/ios/Flutter/flutter_export_environment.sh index fae63896..03bce7c9 100755 --- a/example/ios/Flutter/flutter_export_environment.sh +++ b/example/ios/Flutter/flutter_export_environment.sh @@ -3,11 +3,12 @@ export "FLUTTER_ROOT=/Users/lorenzopichilli/fvm/versions/2.10.4" export "FLUTTER_APPLICATION_PATH=/Users/lorenzopichilli/Desktop/flutter_inappwebview/example" export "COCOAPODS_PARALLEL_CODE_SIGN=true" -export "FLUTTER_TARGET=lib/main.dart" +export "FLUTTER_TARGET=integration_test/webview_flutter_test.dart" export "FLUTTER_BUILD_DIR=build" export "FLUTTER_BUILD_NAME=1.0.0" export "FLUTTER_BUILD_NUMBER=1" +export "DART_DEFINES=RkxVVFRFUl9XRUJfQVVUT19ERVRFQ1Q9dHJ1ZQ==" export "DART_OBFUSCATION=false" export "TRACK_WIDGET_CREATION=true" export "TREE_SHAKE_ICONS=false" -export "PACKAGE_CONFIG=.dart_tool/package_config.json" +export "PACKAGE_CONFIG=/Users/lorenzopichilli/Desktop/flutter_inappwebview/example/.dart_tool/package_config.json" diff --git a/ios/Classes/FindInteraction/FindInteractionChannelDelegate.swift b/ios/Classes/FindInteraction/FindInteractionChannelDelegate.swift index c0bd9383..950f622a 100644 --- a/ios/Classes/FindInteraction/FindInteractionChannelDelegate.swift +++ b/ios/Classes/FindInteraction/FindInteractionChannelDelegate.swift @@ -134,8 +134,8 @@ public class FindInteractionChannelDelegate : ChannelDelegate { public func onFindResultReceived(activeMatchOrdinal: Int, numberOfMatches: Int, isDoneCounting: Bool) { if isDoneCounting, let findInteractionController = findInteractionController { - findInteractionController.activeFindSession = FindSession(resultCount: activeMatchOrdinal, - highlightedResultIndex: numberOfMatches, + findInteractionController.activeFindSession = FindSession(resultCount: numberOfMatches, + highlightedResultIndex: activeMatchOrdinal, searchResultDisplayStyle: 2) // matches UIFindSession.SearchResultDisplayStyle.none }