merged fix(ios): invoke onBrowserCreated when viewDidLoad is called with win…, updated webview debug settings, updated debug logging message with platform name

This commit is contained in:
Lorenzo Pichilli 2022-10-13 21:18:07 +02:00
parent 9da39036a4
commit 45c3652bc5
9 changed files with 14 additions and 7 deletions

View File

@ -28,7 +28,7 @@
- Removed `URLProtectionSpace.iosIsProxy` property - Removed `URLProtectionSpace.iosIsProxy` property
- `historyUrl` and `baseUrl` of `InAppWebViewInitialData` can be `null` - `historyUrl` and `baseUrl` of `InAppWebViewInitialData` can be `null`
## 5.4.5 ## 5.5.0
- Added Android direct camera capture feature - Added Android direct camera capture feature
- Fixed missing `PullToRefreshController.isRefreshing` iOS implementation - Fixed missing `PullToRefreshController.isRefreshing` iOS implementation
@ -46,6 +46,7 @@
- Merged "Catch and ignore utf8 format exception in getFavicons()" [#1302](https://github.com/pichillilorenzo/flutter_inappwebview/pull/1302) (thanks to [Doflatango](https://github.com/Doflatango)) - Merged "Catch and ignore utf8 format exception in getFavicons()" [#1302](https://github.com/pichillilorenzo/flutter_inappwebview/pull/1302) (thanks to [Doflatango](https://github.com/Doflatango))
- Merged "Disable exporting activity definitions for Android" [#1313](https://github.com/pichillilorenzo/flutter_inappwebview/pull/1313) (thanks to [daanporon](https://github.com/daanporon)) - Merged "Disable exporting activity definitions for Android" [#1313](https://github.com/pichillilorenzo/flutter_inappwebview/pull/1313) (thanks to [daanporon](https://github.com/daanporon))
- Merged "Add directoryIndex and documentRoot to InAppLocalhostServer option" [#1319](https://github.com/pichillilorenzo/flutter_inappwebview/pull/1319) (thanks to [fa0311](https://github.com/fa0311)) - Merged "Add directoryIndex and documentRoot to InAppLocalhostServer option" [#1319](https://github.com/pichillilorenzo/flutter_inappwebview/pull/1319) (thanks to [fa0311](https://github.com/fa0311))
- Merged "fix(ios): invoke onBrowserCreated when viewDidLoad is called with win…" [#1344](https://github.com/pichillilorenzo/flutter_inappwebview/pull/1344) (thanks to [perffecto](https://github.com/perffecto))
## 5.4.4+3 ## 5.4.4+3

View File

@ -128,6 +128,7 @@ public class InAppBrowserWebViewController: UIViewController, InAppBrowserDelega
if let wId = windowId, let webViewTransport = InAppWebView.windowWebViews[wId] { if let wId = windowId, let webViewTransport = InAppWebView.windowWebViews[wId] {
webView?.load(webViewTransport.request) webView?.load(webViewTransport.request)
channelDelegate?.onBrowserCreated()
} else { } else {
if #available(iOS 11.0, *) { if #available(iOS 11.0, *) {
if let contentBlockers = webView?.settings?.contentBlockers, contentBlockers.count > 0 { if let contentBlockers = webView?.settings?.contentBlockers, contentBlockers.count > 0 {

View File

@ -80,7 +80,7 @@ class ChromeSafariBrowser {
} }
var maxLogMessageLength = var maxLogMessageLength =
ChromeSafariBrowser.debugLoggingSettings.maxLogMessageLength; ChromeSafariBrowser.debugLoggingSettings.maxLogMessageLength;
String message = "ChromeSafariBrowser ID " + String message = "(${defaultTargetPlatform.name}) ChromeSafariBrowser ID " +
id + id +
" calling \"" + " calling \"" +
method.toString() + method.toString() +

View File

@ -1,5 +1,6 @@
import 'dart:developer' as developer; import 'dart:developer' as developer;
import 'package:flutter/foundation.dart';
import 'package:flutter/services.dart'; import 'package:flutter/services.dart';
import '../in_app_webview/in_app_webview_settings.dart'; import '../in_app_webview/in_app_webview_settings.dart';
import '../debug_logging_settings.dart'; import '../debug_logging_settings.dart';
@ -58,7 +59,7 @@ class FindInteractionController {
} }
var maxLogMessageLength = var maxLogMessageLength =
FindInteractionController.debugLoggingSettings.maxLogMessageLength; FindInteractionController.debugLoggingSettings.maxLogMessageLength;
String message = "FindInteractionController " + String message = "(${defaultTargetPlatform.name}) FindInteractionController " +
" calling \"" + " calling \"" +
method.toString() + method.toString() +
"\" using " + "\" using " +

View File

@ -2,6 +2,7 @@ import 'dart:async';
import 'dart:collection'; import 'dart:collection';
import 'dart:developer' as developer; import 'dart:developer' as developer;
import 'package:flutter/foundation.dart';
import 'package:flutter/services.dart'; import 'package:flutter/services.dart';
import '../context_menu.dart'; import '../context_menu.dart';
@ -108,7 +109,7 @@ class InAppBrowser {
} }
var maxLogMessageLength = var maxLogMessageLength =
InAppBrowser.debugLoggingSettings.maxLogMessageLength; InAppBrowser.debugLoggingSettings.maxLogMessageLength;
String message = "InAppBrowser ID " + String message = "(${defaultTargetPlatform.name}) InAppBrowser ID " +
id + id +
" calling \"" + " calling \"" +
method.toString() + method.toString() +

View File

@ -118,7 +118,8 @@ class InAppWebViewController {
var maxLogMessageLength = var maxLogMessageLength =
WebView.debugLoggingSettings.maxLogMessageLength; WebView.debugLoggingSettings.maxLogMessageLength;
String viewId = (getViewId() ?? _inAppBrowser?.id).toString(); String viewId = (getViewId() ?? _inAppBrowser?.id).toString();
String message = (_inAppBrowser == null ? "WebView" : "InAppBrowser") + String message = "(${defaultTargetPlatform.name}) " +
(_inAppBrowser == null ? "WebView" : "InAppBrowser") +
" ID " + " ID " +
viewId + viewId +
" calling \"" + " calling \"" +

View File

@ -21,6 +21,7 @@ abstract class WebView {
///Debug settings used by [InAppWebView], [HeadlessInAppWebView] and [InAppBrowser]. ///Debug settings used by [InAppWebView], [HeadlessInAppWebView] and [InAppBrowser].
///The default value excludes the [WebView.onScrollChanged], [WebView.onOverScrolled] and [WebView.onReceivedIcon] events. ///The default value excludes the [WebView.onScrollChanged], [WebView.onOverScrolled] and [WebView.onReceivedIcon] events.
static DebugLoggingSettings debugLoggingSettings = DebugLoggingSettings( static DebugLoggingSettings debugLoggingSettings = DebugLoggingSettings(
maxLogMessageLength: 1000,
excludeFilter: [ excludeFilter: [
RegExp(r"onScrollChanged"), RegExp(r"onScrollChanged"),
RegExp(r"onOverScrolled"), RegExp(r"onOverScrolled"),

View File

@ -1,5 +1,6 @@
import 'dart:developer' as developer; import 'dart:developer' as developer;
import 'package:flutter/foundation.dart';
import 'package:flutter/services.dart'; import 'package:flutter/services.dart';
import '../in_app_webview/webview.dart'; import '../in_app_webview/webview.dart';
import '../in_app_browser/in_app_browser.dart'; import '../in_app_browser/in_app_browser.dart';
@ -65,7 +66,7 @@ class PullToRefreshController {
} }
var maxLogMessageLength = var maxLogMessageLength =
PullToRefreshController.debugLoggingSettings.maxLogMessageLength; PullToRefreshController.debugLoggingSettings.maxLogMessageLength;
String message = "PullToRefreshController " + String message = "(${defaultTargetPlatform.name}) PullToRefreshController " +
" calling \"" + " calling \"" +
method.toString() + method.toString() +
"\" using " + "\" using " +

View File

@ -120,7 +120,7 @@ class WebAuthenticationSession implements Disposable {
} }
var maxLogMessageLength = var maxLogMessageLength =
WebAuthenticationSession.debugLoggingSettings.maxLogMessageLength; WebAuthenticationSession.debugLoggingSettings.maxLogMessageLength;
String message = "WebAuthenticationSession ID " + String message = "(${defaultTargetPlatform.name}) WebAuthenticationSession ID " +
id + id +
" calling \"" + " calling \"" +
method.toString() + method.toString() +