rogalikkkkkk
/
iosWebViewFix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1302 from Doflatango/fix/get_favicons_exception 

Catch and ignore utf8 format exception in getFavicons()
This commit is contained in:
Lorenzo Pichilli 2022-10-13 19:53:55 +02:00 committed by GitHub
parent ebd887846f 3b735a7965
commit 741eb3964a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/src/in_app_webview/in_app_webview_controller.dart
View File

@ -1096,13 +1096,18 @@ class InAppWebViewController {
} }
if (manifestFound) { if (manifestFound) {
Map<String, dynamic> manifest = try {
json.decode(await manifestResponse!.transform(Utf8Decoder()).join()); Map<String, dynamic> manifest =
if (manifest.containsKey("icons")) { json.decode(await manifestResponse!.transform(Utf8Decoder()).join());
for (Map<String, dynamic> icon in manifest["icons"]) { if (manifest.containsKey("icons")) {
favicons.addAll(_createFavicons(webviewUrl, assetPathBase, for (Map<String, dynamic> icon in manifest["icons"]) {
icon["src"], icon["rel"], icon["sizes"], true)); favicons.addAll(_createFavicons(webviewUrl, assetPathBase,
icon["src"], icon["rel"], icon["sizes"], true));
}
} }
} on FormatException catch (_) {
/// The [manifestResponse] might not has a valid JSON string, catch and
/// ignore the error
} }
} }