rogalikkkkkk
/
iosWebViewFix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1201 from emakar/fix-android-leak 

[Android] fix leaking `MethodChannel` through anonymous class
This commit is contained in:
Lorenzo Pichilli 2022-10-13 15:36:18 +02:00 committed by GitHub
parent e46523aef3 bd6e2548fc
commit f573f8afe5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
android/src/main/java/com/pichillilorenzo/flutter_inappwebview/ServiceWorkerManager.java
View File

@ -168,13 +168,7 @@ public class ServiceWorkerManager implements MethodChannel.MethodCallHandler {
} }
private ServiceWorkerClientCompat dummyServiceWorkerClientCompat() { private ServiceWorkerClientCompat dummyServiceWorkerClientCompat() {
return new ServiceWorkerClientCompat() { return DummyServiceWorkerClientCompat.INSTANCE;
@Nullable
@Override
public WebResourceResponse shouldInterceptRequest(@NonNull WebResourceRequest request) {
return null;
}
};
} }
public void dispose() { public void dispose() {
@ -185,4 +179,14 @@ public class ServiceWorkerManager implements MethodChannel.MethodCallHandler {
} }
plugin = null; plugin = null;
} }
private static final class DummyServiceWorkerClientCompat extends ServiceWorkerClientCompat {
static final ServiceWorkerClientCompat INSTANCE = new DummyServiceWorkerClientCompat();
@Nullable
@Override
public WebResourceResponse shouldInterceptRequest(@NonNull WebResourceRequest request) {
return null;
}
}
} }